-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pbl tapering #1910
Pbl tapering #1910
Conversation
@jkbk2004 This PR is for a few lines of code in the stochastic physics repo and is a very minor change. I ran the full suite of regression tests on hera, and they all pass. Can this get added to an existing regression test in the queue since EMC needs this for the next ensemble protoype? |
I have no idea on the next ensemble prototype. Could you contact Bing Fu who is now a GEFS leader? |
@JongilHan66 Hi Jongil, we will start running EP5 experiment on Oct 1. The EP5 tag will be created based on the model including this PR, please help to merge it at the earliest convenience. |
@JongilHan66 I meant to tag Jong Kim, not you. |
Then I think the comments should go to Jong Kim @jkbk2004 |
PR #1904 has been merged with this PR. |
@pjpegion Can you go ahead to sync up? No baseline change, so we can let tests move on. |
done |
It looks like the sub component PR dependency was already merged into its authoritative branch. @pjpegion could you revert .gtimodules and update the hash for stochastic physics? |
@pjpegion can you update the description of this PR since it merged in #1904 It closes issue #1898 and includes an update to be able to run the cellular automata on a single face tile. It also includes an update to ensure that consistent decomposition between the FV3 domain and the higher resolution CA domain. |
Looks like there are failures on the jenkins ci side due to allocation being exceeded again, running manually on hera. |
I'll work with platform today to get the issue fixed. |
I was traveling yesterday. Do you still need me to update .gitmodules? |
Yes please go ahead and revert .gitmodules and update the hash for stochastic as the sub PR is already merged in |
ok, done |
WCOSS has 2 timeouts, but there is a known machine issue with slowness. I've verified with more time the tests pass, but will not be making any changes to the UFS code at this time. |
Ok this should be ready for merging, continuing with final reviews |
PR Author Checklist:
Description
This PR adds additional tapering of the SPPT perturbations in the lower levels of the atmospheric model
From the included #1904 which closes #1898:
Add possibility to run the CA on a single tile by adding a cubed-sphere, single face tile with no contact surfaces in the CA domain specification.
Ensure decomposition of domain is proportional between the atmosphere domain and the higher resolution CA domain.
Linked Issues and Pull Requests
Associated UFSWM Issue to close
Closes: #1908
Subcomponent Pull Requests
Blocking Dependencies
None
Subcomponents involved:
Anticipated Changes
Input data
Regression Tests:
Tests effected by changes in this PR:
Libraries
Code Managers Log
Testing Log: